entrycompletion: set_property() should call property setters
authorPavel Holejsovsky <pavel.holejsovsky@gmail.com>
Fri, 23 Mar 2012 06:09:02 +0000 (07:09 +0100)
committerPavel Holejsovsky <pavel.holejsovsky@gmail.com>
Sun, 8 Apr 2012 10:10:44 +0000 (12:10 +0200)
commit331bba1ad6c5d9535fc5a827b91019f5824e25a7
tree7b0f1497592b101ad506cf4520f2b5691903eb43
parentdf37446f9b4116887865b7ecfddeb535fbc0eacb
entrycompletion: set_property() should call property setters

gtk_entry_completion_set_property() was setting many properties by
directly modifying priv values, bypassing notification invocation and
possibly another actions done by gtk_completion_entry_set_xxx ()
functions.  Fix by invoking set_xxx() instead of setting the property
value directly.

The real bug observerd was that setting text-column property using
g_object_set() caused SIGFPE later when entry completion was about to
appear.  gtk_entry_completion_set_text_column () apparently does way
more important things than just setting priv->text_column member.

https://bugzilla.gnome.org/show_bug.cgi?id=673693
gtk/gtkentrycompletion.c